mig5/bouquin
1
0
Fork 0
Code Issues Pull requests Releases 54 Wiki Activity Actions

Fix reminders tests from segfaulting
All checks were successful
CI / test (push) Successful in 5m43s
Details
Lint / test (push) Successful in 33s
Details
Trivy / test (push) Successful in 24s
Details

Browse source
This commit is contained in:
Miguel Jacq 2025-12-02 09:45:54 +11:00
parent 422411f12e
commit 25f0c28582
Signed by: mig5
GPG key ID: 59B3F0C24135C6A9
1 changed files with 63 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

47
tests/test_reminders.py
View file

@ -1,6 +1,6 @@
import pytest
from unittest.mock import patch
from unittest.mock import patch, MagicMock
from bouquin.reminders import (
Reminder,
ReminderType,
@ -302,15 +302,19 @@ def test_upcoming_reminders_widget_add_reminder(qtbot, app, fresh_db):
widget = UpcomingRemindersWidget(fresh_db)
qtbot.addWidget(widget)
with patch.object(ReminderDialog, "exec", return_value=QDialog.Accepted):
with patch.object(ReminderDialog, "get_reminder") as mock_get:
mock_get.return_value = Reminder(
new_reminder = Reminder(
id=None,
text="New reminder",
time_str="10:00",
reminder_type=ReminderType.DAILY,
)
# Mock the entire ReminderDialog class to avoid Qt parent issues
mock_dialog = MagicMock()
mock_dialog.exec.return_value = QDialog.Accepted
mock_dialog.get_reminder.return_value = new_reminder
with patch("bouquin.reminders.ReminderDialog", return_value=mock_dialog):
widget._add_reminder()
# Reminder should be saved
@ -338,16 +342,19 @@ def test_upcoming_reminders_widget_edit_reminder(qtbot, app, fresh_db):
if widget.reminder_list.count() > 0:
item = widget.reminder_list.item(0)
with patch.object(ReminderDialog, "exec", return_value=QDialog.Accepted):
with patch.object(ReminderDialog, "get_reminder") as mock_get:
updated = Reminder(
id=1,
text="Updated",
time_str="11:00",
reminder_type=ReminderType.DAILY,
)
mock_get.return_value = updated
# Mock the entire ReminderDialog class to avoid Qt parent issues
mock_dialog = MagicMock()
mock_dialog.exec.return_value = QDialog.Accepted
mock_dialog.get_reminder.return_value = updated
with patch("bouquin.reminders.ReminderDialog", return_value=mock_dialog):
widget._edit_reminder(item)
@ -463,15 +470,19 @@ def test_manage_reminders_dialog_add_reminder(qtbot, app, fresh_db):
initial_count = dialog.table.rowCount()
with patch.object(ReminderDialog, "exec", return_value=QDialog.Accepted):
with patch.object(ReminderDialog, "get_reminder") as mock_get:
mock_get.return_value = Reminder(
new_reminder = Reminder(
id=None,
text="New",
time_str="10:00",
reminder_type=ReminderType.DAILY,
)
# Mock the entire ReminderDialog class to avoid Qt parent issues
mock_dialog = MagicMock()
mock_dialog.exec.return_value = QDialog.Accepted
mock_dialog.get_reminder.return_value = new_reminder
with patch("bouquin.reminders.ReminderDialog", return_value=mock_dialog):
dialog._add_reminder()
# Table should have one more row
@ -492,15 +503,19 @@ def test_manage_reminders_dialog_edit_reminder(qtbot, app, fresh_db):
dialog = ManageRemindersDialog(fresh_db)
qtbot.addWidget(dialog)
with patch.object(ReminderDialog, "exec", return_value=QDialog.Accepted):
with patch.object(ReminderDialog, "get_reminder") as mock_get:
mock_get.return_value = Reminder(
updated = Reminder(
id=1,
text="Updated",
time_str="11:00",
reminder_type=ReminderType.DAILY,
)
# Mock the entire ReminderDialog class to avoid Qt parent issues
mock_dialog = MagicMock()
mock_dialog.exec.return_value = QDialog.Accepted
mock_dialog.get_reminder.return_value = updated
with patch("bouquin.reminders.ReminderDialog", return_value=mock_dialog):
dialog._edit_reminder(reminder)
@ -627,7 +642,11 @@ def test_upcoming_reminders_widget_manage_button(qtbot, app, fresh_db):
widget = UpcomingRemindersWidget(fresh_db)
qtbot.addWidget(widget)
with patch.object(ManageRemindersDialog, "exec"):
# Mock the entire ManageRemindersDialog class to avoid Qt parent issues
mock_dialog = MagicMock()
mock_dialog.exec.return_value = QDialog.Accepted
with patch("bouquin.reminders.ManageRemindersDialog", return_value=mock_dialog):
widget._manage_reminders()