mig5/bouquin
1
0
Fork 0
Code Issues Pull requests Releases 54 Wiki Activity Actions

Don't show 'day' label in Reminders unless day choice is selected
All checks were successful
CI / test (push) Successful in 5m19s
Details
Lint / test (push) Successful in 32s
Details
Trivy / test (push) Successful in 24s
Details

Browse source
This commit is contained in:
Miguel Jacq 2025-11-29 16:16:40 +11:00
parent 9db4cda8cc
commit 9ab70c76f8
Signed by: mig5
GPG key ID: 59B3F0C24135C6A9
1 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
bouquin/reminders.py
View file

@ -64,13 +64,13 @@ class ReminderDialog(QDialog):
self.setMinimumWidth(400) self.setMinimumWidth(400)
layout = QVBoxLayout(self) layout = QVBoxLayout(self)
form = QFormLayout() self.form = QFormLayout()
# Reminder text # Reminder text
self.text_edit = QLineEdit() self.text_edit = QLineEdit()
if reminder: if reminder:
self.text_edit.setText(reminder.text) self.text_edit.setText(reminder.text)
form.addRow("&" + strings._("reminder") + ":", self.text_edit) self.form.addRow("&" + strings._("reminder") + ":", self.text_edit)
# Time # Time
self.time_edit = QTimeEdit() self.time_edit = QTimeEdit()
@ -80,7 +80,7 @@ class ReminderDialog(QDialog):
self.time_edit.setTime(QTime(int(parts[0]), int(parts[1]))) self.time_edit.setTime(QTime(int(parts[0]), int(parts[1])))
else: else:
self.time_edit.setTime(QTime.currentTime()) self.time_edit.setTime(QTime.currentTime())
form.addRow("&" + strings._("time") + ":", self.time_edit) self.form.addRow("&" + strings._("time") + ":", self.time_edit)
# Recurrence type # Recurrence type
self.type_combo = QComboBox() self.type_combo = QComboBox()
@ -96,7 +96,7 @@ class ReminderDialog(QDialog):
break break
self.type_combo.currentIndexChanged.connect(self._on_type_changed) self.type_combo.currentIndexChanged.connect(self._on_type_changed)
form.addRow("&" + strings._("repeat") + ":", self.type_combo) self.form.addRow("&" + strings._("repeat") + ":", self.type_combo)
# Weekday selector (for weekly reminders) # Weekday selector (for weekly reminders)
self.weekday_combo = QComboBox() self.weekday_combo = QComboBox()
@ -117,9 +117,11 @@ class ReminderDialog(QDialog):
else: else:
self.weekday_combo.setCurrentIndex(QDate.currentDate().dayOfWeek() - 1) self.weekday_combo.setCurrentIndex(QDate.currentDate().dayOfWeek() - 1)
form.addRow("&" + strings._("day") + ":", self.weekday_combo) self.form.addRow("&" + strings._("day") + ":", self.weekday_combo)
day_label = self.form.labelForField(self.weekday_combo)
day_label.setVisible(False)
layout.addLayout(form) layout.addLayout(self.form)
# Buttons # Buttons
btn_layout = QHBoxLayout() btn_layout = QHBoxLayout()
@ -142,6 +144,8 @@ class ReminderDialog(QDialog):
"""Show/hide weekday selector based on reminder type.""" """Show/hide weekday selector based on reminder type."""
reminder_type = self.type_combo.currentData() reminder_type = self.type_combo.currentData()
self.weekday_combo.setVisible(reminder_type == ReminderType.WEEKLY) self.weekday_combo.setVisible(reminder_type == ReminderType.WEEKLY)
day_label = self.form.labelForField(self.weekday_combo)
day_label.setVisible(reminder_type == ReminderType.WEEKLY)
def get_reminder(self) -> Reminder: def get_reminder(self) -> Reminder:
"""Get the configured reminder.""" """Get the configured reminder."""